Skip to content

Updated to open ChromeTabs instead of full chrome #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MostafaGazar merged 1 commit into from
Sep 23, 2019
Merged

Updated to open ChromeTabs instead of full chrome #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ dependencies {
// Timber
implementation 'com.jakewharton.timber:timber:4.7.1'

// Custom Tabs
implementation 'androidx.browser:browser:1.0.0'

// Testing
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.2.0'
Expand Down
16 changes: 6 additions & 10 deletions app/src/main/java/com/koalatea/sedaily/util/UiExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ package com.koalatea.sedaily.util
import android.app.Activity
import android.app.ActivityManager
import android.content.Context
import android.content.Intent
import android.net.Uri
import android.util.TypedValue
import android.view.inputmethod.InputMethodManager
import androidx.appcompat.app.AppCompatActivity
import androidx.browser.customtabs.CustomTabsIntent
import androidx.fragment.app.Fragment
import androidx.navigation.NavController
import androidx.navigation.ui.AppBarConfiguration
Expand Down Expand Up @@ -46,16 +46,12 @@ fun Fragment.openUrl(url: String): Boolean {
url
}

val intent = Intent(Intent.ACTION_VIEW).setData(Uri.parse(validUrl))
CustomTabsIntent.Builder()
.setShowTitle(true)
.build()
.launchUrl(context, Uri.parse(validUrl))

val context = this.context
if (context != null && intent.resolveActivity(context.packageManager) != null) {
startActivity(intent)

return true
}

return false
return true
} catch (e: Exception) {
Timber.e(e)

Expand Down