Share form change #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrWichlinskiSoftwaremind
force-pushed
the
share_form_change
branch
2 times, most recently
from
53371aa to
ce4c7ef
Compare
dagl
requested changes
Aug 23, 2022
cs3api4lab/api/cs3_ocm_share_api.py
Outdated
| elif stat_response.status.code == cs3_code.CODE_NOT_FOUND: | ||
| raise ResourceNotFoundError("Resource not found") | ||
| else: | ||
| self._handle_error(stat_response) |
cs3api4lab/api/cs3_user_api.py
Outdated
|
|
||
| def get_user(self, idp, opaque_id): | ||
| user_info = self.get_user_info(idp, opaque_id) | ||
| if not bool(user_info) and self.config['enable_ocm']: |
There was a problem hiding this comment.
no need for explicit conversion to bool
|
|
||
| file_path = FileUtils.remove_drives_names(file_path) | ||
| file_path = ShareUtils.purify_file_path(file_path, self.config.client_id) | ||
| shares = [] |
There was a problem hiding this comment.
can be
shares = [ShareUtils.get_share_info(share) for share in all_shares_list]
|
|
||
| @skip | ||
| class TestCs3OcmShareApi(TestCase): | ||
| class TestCs3ShareApi(TestCase): |
There was a problem hiding this comment.
it shouldn't, I've changed it back
| from unittest import TestCase | ||
| from cs3api4lab.exception.exceptions import ShareError, ResourceNotFoundError | ||
|
|
||
| from cs3api4lab.exception.exceptions import * |
There was a problem hiding this comment.
wildcard imports should be avoided, instead:
from cs3api4lab.exception.exceptions import ShareError, ResourceNotFoundError, ShareNotFoundError
There was a problem hiding this comment.
done
| """ | ||
| This tests checks if share_api.get() single share raises an exception when incorrect id is given | ||
| """ | ||
| random_id = self.get_random_suffix() |
There was a problem hiding this comment.
can just be some made up id, doesn't have to be random
There was a problem hiding this comment.
done
| """This test if share_api.remove raises an error when share doesn't exist""" | ||
|
|
||
| with self.assertRaises(Exception) as context: | ||
| self.share_api.remove(self.get_random_suffix()) |
There was a problem hiding this comment.
done
| """ | ||
|
|
||
| try: | ||
| self.file_name = self.file_path + self.get_random_suffix() |
piotrWichlinskiSoftwaremind
force-pushed
the
share_form_change
branch
3 times, most recently
from
b93678a to
133ad93
Compare
piotrWichlinskiSoftwaremind
force-pushed
the
share_form_change
branch
from
133ad93 to
6115852
Compare
piotrWichlinskiSoftwaremind
force-pushed
the
share_form_change
branch
2 times, most recently
from
646b2d2 to
0a4d007
Compare
piotrWichlinskiSoftwaremind
force-pushed
the
share_form_change
branch
3 times, most recently
from
77518b8 to
52edf23
Compare
piotrWichlinskiSoftwaremind
force-pushed
the
share_form_change
branch
from
52edf23 to
0238d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.