Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html

Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)

Author: nerli1

accessible/base/EventQueue.cpp

@@ -268,7 +268,8 @@ void EventQueue::CoalesceSelChangeEvents(AccSelChangeEvent* aTailEvent,
 
 void EventQueue::ProcessEventQueue() {
   // Process only currently queued events.
-  const nsTArray<RefPtr<AccEvent> > events = std::move(mEvents);
+  nsTArray<RefPtr<AccEvent> > events;
+  events.SwapElements(mEvents);
 
   uint32_t eventCount = events.Length();
 #ifdef A11Y_LOG

accessible/base/NotificationController.cpp

@@ -827,8 +827,8 @@ void NotificationController::WillRefresh(mozilla::TimeStamp aTime) {
   // etc. Therefore, they must be processed after relocations, since relocated
   // subtrees might not have been created before relocation processing and the
   // target might be inside a relocated subtree.
-  const nsTArray<RefPtr<Notification>> notifications =
-      std::move(mNotifications);
+  nsTArray<RefPtr<Notification>> notifications;
+  notifications.SwapElements(mNotifications);
 
   uint32_t notificationCount = notifications.Length();
   for (uint32_t idx = 0; idx < notificationCount; idx++) {

accessible/ipc/other/DocAccessibleChild.cpp

@@ -177,7 +177,7 @@ static void AddRelation(Accessible* aAcc, RelationType aType,
   if (!targets.IsEmpty()) {
     RelationTargets* newRelation = aTargets->AppendElement(
         RelationTargets(static_cast<uint32_t>(aType), nsTArray<uint64_t>()));
-    newRelation->Targets() = std::move(targets);
+    newRelation->Targets().SwapElements(targets);
   }
 }
 

docshell/base/timeline/ObservedDocShell.cpp

@@ -163,7 +163,7 @@ void ObservedDocShell::PopMarkers(
     }
   }
 
-  mTimelineMarkers = std::move(keptStartMarkers);
+  mTimelineMarkers.SwapElements(keptStartMarkers);
 }
 
 }  // namespace mozilla

dom/animation/AnimationEventDispatcher.h

@@ -156,7 +156,8 @@ class AnimationEventDispatcher final {
 
     SortEvents();
 
-    EventArray events = std::move(mPendingEvents);
+    EventArray events;
+    mPendingEvents.SwapElements(events);
     // mIsSorted will be set to true by SortEvents above, and we leave it
     // that way since mPendingEvents is now empty
     for (AnimationEventInfo& info : events) {

dom/animation/KeyframeEffect.cpp

@@ -881,7 +881,7 @@ nsTArray<AnimationProperty> KeyframeEffect::BuildProperties(
              " should not be modified");
 #endif
 
-  mKeyframes = std::move(keyframesCopy);
+  mKeyframes.SwapElements(keyframesCopy);
   return result;
 }
 

dom/base/DOMIntersectionObserver.cpp

@@ -256,7 +256,8 @@ void DOMIntersectionObserver::Disconnect() {
 
 void DOMIntersectionObserver::TakeRecords(
     nsTArray<RefPtr<DOMIntersectionObserverEntry>>& aRetVal) {
-  aRetVal = std::move(mQueuedEntries);
+  aRetVal.SwapElements(mQueuedEntries);
+  mQueuedEntries.Clear();
 }
 
 static Maybe<nsRect> EdgeInclusiveIntersection(const nsRect& aRect,

dom/base/Document.cpp

@@ -6262,7 +6262,7 @@ void Document::UpdateFrameRequestCallbackSchedulingState(
 
 void Document::TakeFrameRequestCallbacks(nsTArray<FrameRequest>& aCallbacks) {
   MOZ_ASSERT(aCallbacks.IsEmpty());
-  aCallbacks = std::move(mFrameRequestCallbacks);
+  aCallbacks.SwapElements(mFrameRequestCallbacks);
   mCanceledFrameRequestCallbacks.clear();
   // No need to manually remove ourselves from the refresh driver; it will
   // handle that part.  But we do have to update our state.
@@ -8573,8 +8573,8 @@ void Document::MaybeInitializeFinalizeFrameLoaders() {
 
   uint32_t length = mFrameLoaderFinalizers.Length();
   if (length > 0) {
-    nsTArray<nsCOMPtr<nsIRunnable>> finalizers =
-        std::move(mFrameLoaderFinalizers);
+    nsTArray<nsCOMPtr<nsIRunnable>> finalizers;
+    mFrameLoaderFinalizers.SwapElements(finalizers);
     for (uint32_t i = 0; i < length; ++i) {
       finalizers[i]->Run();
     }
@@ -11687,9 +11687,10 @@ bool Document::IsDocumentRightToLeft() {
 
 class nsDelayedEventDispatcher : public Runnable {
  public:
-  explicit nsDelayedEventDispatcher(nsTArray<nsCOMPtr<Document>>&& aDocuments)
-      : mozilla::Runnable("nsDelayedEventDispatcher"),
-        mDocuments(std::move(aDocuments)) {}
+  explicit nsDelayedEventDispatcher(nsTArray<nsCOMPtr<Document>>& aDocuments)
+      : mozilla::Runnable("nsDelayedEventDispatcher") {
+    mDocuments.SwapElements(aDocuments);
+  }
   virtual ~nsDelayedEventDispatcher() = default;
 
   NS_IMETHOD Run() override {
@@ -11721,17 +11722,16 @@ void Document::UnsuppressEventHandlingAndFireEvents(bool aFireEvents) {
 
   if (aFireEvents) {
     MOZ_RELEASE_ASSERT(NS_IsMainThread());
-    nsCOMPtr<nsIRunnable> ded =
-        new nsDelayedEventDispatcher(std::move(documents));
+    nsCOMPtr<nsIRunnable> ded = new nsDelayedEventDispatcher(documents);
     Dispatch(TaskCategory::Other, ded.forget());
   } else {
     FireOrClearDelayedEvents(documents, false);
   }
 
   if (!EventHandlingSuppressed()) {
     MOZ_ASSERT(NS_IsMainThread());
-    nsTArray<RefPtr<net::ChannelEventQueue>> queues =
-        std::move(mSuspendedQueues);
+    nsTArray<RefPtr<net::ChannelEventQueue>> queues;
+    mSuspendedQueues.SwapElements(queues);
     for (net::ChannelEventQueue* queue : queues) {
       queue->Resume();
     }
@@ -11767,8 +11767,8 @@ bool Document::SuspendPostMessageEvent(PostMessageEvent* aEvent) {
 }
 
 void Document::FireOrClearPostMessageEvents(bool aFireEvents) {
-  nsTArray<RefPtr<PostMessageEvent>> events =
-      std::move(mSuspendedPostMessageEvents);
+  nsTArray<RefPtr<PostMessageEvent>> events;
+  events.SwapElements(mSuspendedPostMessageEvents);
 
   if (aFireEvents) {
     for (PostMessageEvent* event : events) {

dom/base/Navigator.cpp

@@ -711,7 +711,8 @@ void VibrateWindowListener::RemoveListener() {
 void Navigator::SetVibrationPermission(bool aPermitted, bool aPersistent) {
   MOZ_ASSERT(NS_IsMainThread());
 
-  nsTArray<uint32_t> pattern = std::move(mRequestedVibrationPattern);
+  nsTArray<uint32_t> pattern;
+  pattern.SwapElements(mRequestedVibrationPattern);
 
   if (!mWindow) {
     return;
@@ -786,7 +787,7 @@ bool Navigator::Vibrate(const nsTArray<uint32_t>& aPattern) {
     return true;
   }
 
-  mRequestedVibrationPattern = std::move(pattern);
+  mRequestedVibrationPattern.SwapElements(pattern);
 
   PermissionDelegateHandler* permissionHandler =
       doc->GetPermissionDelegateHandler();

dom/base/SameProcessMessageQueue.cpp

@@ -29,7 +29,8 @@ void SameProcessMessageQueue::Push(Runnable* aRunnable) {
 }
 
 void SameProcessMessageQueue::Flush() {
-  const nsTArray<RefPtr<Runnable>> queue = std::move(mQueue);
+  nsTArray<RefPtr<Runnable>> queue;
+  mQueue.SwapElements(queue);
   for (size_t i = 0; i < queue.Length(); i++) {
     queue[i]->Run();
   }