Fix false positive in e2e logfile endpoint test #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 25 25
Lines 879 879
=======================================
Hits 766 766
Misses 113 113 Continue to review full report at Codecov.
|
michaelyaakoby
requested changes
Jun 5, 2020
Wrong usage of text.find method
yanoom
force-pushed
the
yanay_fix_test_e2e_logfile
branch
from
f81efd7 to
8aa179f
Compare
Contributor
Author
|
Now that all fixes have been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on our github tests, I have spotted a bug in test_logfile_endpoint that causes it to always pass (false positive).