Http-traces's timeTaken should be millis between request and response
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When http-traces is capturing a request and response, the `timeTaken` field should be millis between the time the request was received and the time the response was sent. Both `fastapi_pyctuator` and `flask_pyctuator` used the `microseconds` of the `timedelta` between the request time and the response time. Unfortunately, this only returns the microseconds part of the time delta. Instead, should calculate the difference between the two timestamps. Fix #13
michaelyaakoby
force-pushed
the
michael/#13-wrong-request-timing
branch
from
9448509 to
62df9c7
Compare
inbal2l
approved these changes
Jun 22, 2020
inbal2l
left a comment
inbal2l
left a comment
There was a problem hiding this comment.
Thank you for noticing the bug,
and for the fix of course.
Member
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When http-traces is capturing a request and response, the
timeTakenfield should be millis between the time the request was received and the
time the response was sent.
Both
fastapi_pyctuatorandflask_pyctuatorused themicrosecondsof the
timedeltabetween the request time and the response time.Unfortunately, this only returns the microseconds part of the time
delta. Instead, should calculate the difference between the two
timestamps.
Fix #13