Fix issues 20, 22, 23, 24, 25 and 28 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2020 21:33
E2E's test_recurring_registration was extended to verify that deregistration is working properly for all the web frameworks. Note that the actual invocation of test_recurring_registration is registered in `atexit` however in the test its too hard to invoke `atexit` therefore it is called directly. Solves #25
michaelyaakoby
changed the title
Add tests for verifying Pyctuator's support for basic-auth registration with Spring Boot Admin. Solves #28
michaelyaakoby
changed the title
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 88.35% 93.26% +4.91%
==========================================
Files 25 25
Lines 936 936
==========================================
+ Hits 827 873 +46
+ Misses 109 63 -46
Continue to review full report at Codecov.
|
michaelyaakoby
changed the title
michaelyaakoby
force-pushed
the
michael/issues
branch
2 times, most recently
from
8da0488 to
7881856
Compare
michaelyaakoby
force-pushed
the
michael/issues
branch
from
7881856 to
6418662
Compare
michaelyaakoby
changed the title
Member
Author
|
Not sure why codecov isn't updated, but the latest commit brings coverage to (+7.6%): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #20, #22, #23, #24, #25, #28
See commit-comments for details.