Examples should use latest public version of Pyctuator, v0.9.0 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatanRubin
reviewed
May 14, 2020
Member
MatanRubin
left a comment
MatanRubin
left a comment
There was a problem hiding this comment.
Why do we commit lock files for examples? I don't see a reason to do so.
Should we remove them?
michaelyaakoby
force-pushed
the
examples-use-latest-pyctuator
branch
from
9148d1f to
2c1013c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 24 24
Lines 857 857
=======================================
Hits 750 750
Misses 107 107 Continue to review full report at Codecov.
|
Member
Author
|
@MatanRubin you are correct and I've removed the lock files from the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.