Pyctuator should be able to register with SBA that's using basic-auth #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 87.51% 87.03% -0.49%
==========================================
Files 24 24
Lines 857 879 +22
==========================================
+ Hits 750 765 +15
- Misses 107 114 +7
Continue to review full report at Codecov.
|
michaelyaakoby
force-pushed
the
sba-basic-auth
branch
from
a27939a to
f371c09
Compare
yanoom
reviewed
May 18, 2020
michaelyaakoby
force-pushed
the
sba-basic-auth
branch
from
2cfd0f0 to
0797388
Compare
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 87.51% 87.14% -0.38%
==========================================
Files 24 25 +1
Lines 857 879 +22
==========================================
+ Hits 750 766 +16
- Misses 107 113 +6
Continue to review full report at Codecov.
|
MatanRubin
requested changes
May 20, 2020
michaelyaakoby
force-pushed
the
sba-basic-auth
branch
from
0797388 to
12ca1a9
Compare
michaelyaakoby
force-pushed
the
sba-basic-auth
branch
from
12ca1a9 to
4923e42
Compare
It should be possible to configure username and password for Pyctuator to use as basic-authentication when registering to spring-beet-admin. Solves #8 Set Pyctuator version to 0.10
michaelyaakoby
force-pushed
the
sba-basic-auth
branch
from
4923e42 to
5e81e09
Compare
MatanRubin
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to configure username and password for Pyctuator
to use as basic-authentication when registering to spring-beet-admin.
Solves #8