Added methods to filter panes based on user roles (Developer/PowerUser) #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megoth
referenced
this pull request
in SolidOS/folder-pane
Aug 29, 2019
This is dependent on https://github.com/solid/solid-ui/pull/112, so do not merge this until it has been merged and released and the PR has been updated with corresponding release version.
megoth
referenced
this pull request
in SolidOS/solid-panes
Aug 29, 2019
This is dependent on solid/solid-ui#112, so do not merge this until it has been merged and released and the PR has been updated with corresponding release version.
timbl
approved these changes
Aug 29, 2019
Vinnl
approved these changes
Aug 29, 2019
Based on feedback from Vinnl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding methods
filterAvailablePanes(returns which panes a user should see based on their roles) andgetUserRoles(returns roles for a user).This is part of fixing SolidOS/solid-panes#167