Extracted findProfileImage from findImage in setImage #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findImage used to be a private function in UI.widgets.buttons.setImage, but the logic can be reused other places, so I've tried to extract the logic so that it becomes a method exposed as UI.authn.findProfileImage. Partially fixes SolidOS/solid-panes#169
megoth
referenced
this pull request
in SolidOS/mashlib
Sep 16, 2019
Do not merge this until https://github.com/solid/solid-ui/pull/119 is merged and pushed in a new release. This adds solid-ui as a dependency for mashlib. Partial fix for SolidOS/solid-panes#169
Vinnl
approved these changes
Sep 17, 2019
Contributor
Vinnl
left a comment
Vinnl
left a comment
There was a problem hiding this comment.
LGTM. Note that IIRC GitHub doesn't have a notion of "partially fixes", so the description you're currently using would lead GitHub to automatically close the related Issue when merging this even though it wouldn't be fixed yet.
timbl
requested changes
Sep 17, 2019
Contributor
Author
|
@timbl I've updated the API - please check that it looks OK. |
timbl
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findImage used to be a private function in UI.widgets.buttons.setImage, but the logic can be reused other places, so I've tried to extract the logic so that it becomes a method exposed as UI.authn.findProfileImage.
Partially fixes SolidOS/solid-panes#169