Skip to content

Conversation

@megoth
Copy link
Contributor

@megoth megoth commented Nov 7, 2019

@megoth megoth requested a review from Vinnl November 7, 2019 09:09
Copy link
Contributor

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to go ahead with this now, but since it does change doingDefault to doingDefaults and neither of us has any idea what it's supposed to do, it would be good if @timbl could take a look at it still after merging.

@megoth
Copy link
Contributor Author

megoth commented Nov 7, 2019

I cannot find any use of doingDefaults outside of solid-ui and no use of doingDefault at all (and I've checked all projects connected to the data browser). But yes, there might be other projects that use this API that uses doingDefault, so we'll double-check with @timbl .

@megoth megoth merged commit b8b2061 into master Nov 7, 2019
@megoth megoth deleted the revert-byCombo branch November 7, 2019 09:29
@Vinnl
Copy link
Contributor

Vinnl commented Nov 7, 2019

I wasn't really talking about other projects, just that the code you just put back used to refer to doingDefault (which didn't exist) - so whatever that code was supposed to do, it never did it, but it will likely now start doing it. I have no idea about whether that's desirable or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing Permissions not displayed

3 participants