Add ordered option to Multiple field in forms #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megoth
suggested changes
Nov 23, 2019
Contributor
megoth
left a comment
megoth
left a comment
There was a problem hiding this comment.
As I mentioned, The big changes in widgets/forms.js makes it really hard to review...
Also, I think you might benefit from using functional methods such as .reduce, .forEach, and .map in combination with more specialized loops that does one thing each. Using for (...) {...} with a lot of things happening in them can be hard to follow.
package.json
Outdated
| "build-types": "tsc --emitDeclarationOnly", | ||
| "postversion": "git push origin master --follow-tags", | ||
| "prepublishOnly": "npm run build", | ||
| "lint": "prettier-standard --lint 'src/**/*.js' 'src/**/*.ts'", |
Contributor
There was a problem hiding this comment.
I'm doing this in https://github.com/solid/solid-ui/pull/161, please revert these changes
src/acl-control.js
Outdated
|
|
||
| UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) { | ||
| var updater = kb.updater || new $rdf.UpdateManager(kb) | ||
| UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, _callback) { |
Contributor
There was a problem hiding this comment.
This is also done in https://github.com/solid/solid-ui/pull/161, please revert this change from this PR.
| } | ||
|
|
||
| for (let g = 0; g < things.length; g++) { | ||
| var thing = things[g] |
Contributor
There was a problem hiding this comment.
I think a .forEach would better suit this loop, since you only refer to things once.
src/widgets/forms.js
Outdated
| // list.append(object) | ||
| ins = [$rdf.st(subject, property, list)] // Will this work? | ||
| } else { | ||
| const oldList = new $rdf.Collecion(list.elments) |
Contributor
There was a problem hiding this comment.
Typo - $rdf.Collection --> $rdf.Collection
src/widgets/forms.js
Outdated
| } | ||
| list.elements.splice(i, 2, list.elements[i + 1], list.elements[i]) | ||
| } | ||
| saveListThenRefresh() |
Contributor
There was a problem hiding this comment.
Maybe use await before the calls of saveListThenRefresh()?
| // box.appendChild(dom.createElement('h3')).textContent = "Fields:". | ||
| var body = box.appendChild(dom.createElement('tr')) | ||
| var tail = box.appendChild(dom.createElement('tr')) | ||
|
|
Contributor
There was a problem hiding this comment.
Please don't do this big moves of functionality in commits that has other big changes - makes it really hard to review what has changed...
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
TallTed
reviewed
Dec 16, 2019
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Thank you for all your suggestions @TallTed ^_^ Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-Authored-By: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently untested