Fixing bug in regex for phone field #65
Conversation
megoth
force-pushed
the
fix/no-space-in-phone
branch
from
cd7ef18 to
8b1ccce
Compare
src/widgets/index.js
Outdated
| UI.widgets.fieldParams[UI.ns.ui('PhoneField').uri] = { 'size': 20, 'uriPrefix': 'tel:' } | ||
| UI.widgets.fieldParams[UI.ns.ui('PhoneField').uri].pattern = | ||
| /^\s*\+?[ 0-9-]+[0-9]\s*$/ | ||
| /^\s*\+?[0-9-]+[0-9]\s*$/ |
There was a problem hiding this comment.
Shouldn't we also disallow whitespace on either side of the phone number?
There was a problem hiding this comment.
While we're at it, shall we just \d?
There was a problem hiding this comment.
Can do - wanted to keep the changes minimal, as to not introduce any errors (I'm not very good with regex, after all). But I've tried a slight change now, hopefully to the better.
|
I'm fine with merging, so go ahead if you want - just not sure if whitespace at the start or end of a phone number won't cause problems either :) |
megoth
force-pushed
the
fix/no-space-in-phone
branch
from
8b1ccce to
1be10f3
Compare
Tried to improve the regex used - please double-check, then we'll start publishing updates to NPM. |
megoth
changed the title
The regex for phones is still not great, but we'll leave it at this for now until we have a more thorough change of the profile pane