Skip to content

Conversation

@megoth
Copy link
Contributor

@megoth megoth commented Aug 5, 2019

Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I realize the code was right. The spec says you shoudl go up th etree until you find an default ACL, not an ACL file.

@timbl
Copy link
Contributor

timbl commented Aug 5, 2019

Hmmm

Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retract my approval. The original alto was right. It just needs a test for not going too far

@timbl
Copy link
Contributor

timbl commented Aug 5, 2019

tryParent needs to check and exit if there is no acl file atthe root of the domain, to avoid chopping the domain name off

@timbl
Copy link
Contributor

timbl commented Aug 5, 2019

https://github.com/solid/web-access-control-spec/blob/master/README.md
says

Failing that, move up the container hierarchy until you find a container with an existing ACL file, which has some permissions to inherit.

@TallTed
Copy link
Contributor

TallTed commented Aug 6, 2019

Have to remember that "move up the container hierarchy" doesn't necessarily mean "truncate the path, solidus by solidus" as the URI's PATH element may not (though it often will) match the logical container hierarchy. Challenge deepens as Containers identify the Members they contain, but Members don't necessarily identify their Containers.

@megoth
Copy link
Contributor Author

megoth commented Aug 8, 2019

This was handled in https://github.com/solid/solid-ui/pull/80, so closing this PR.

@megoth megoth closed this Aug 8, 2019
@megoth megoth deleted the stop-tryParent-on-200 branch August 12, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants