Refresh sharing on creating and deleting specific acl #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbl
approved these changes
Aug 9, 2019
Contributor
timbl
left a comment
timbl
left a comment
There was a problem hiding this comment.
Looks good to me. The functionality of setting the local store cache state is logically in fetcher() not here .. issue raised about it in fact linkeddata/rdflib.js#331
megoth
deleted the
refresh-sharing-on-creating-and-deleting-specific-acl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some bugs with the sharing pane, but now it is a bit smoother at least