Only adding a slash to destUri if folderName does not already have it #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
approved these changes
Aug 14, 2019
Contributor
Vinnl
left a comment
Vinnl
left a comment
There was a problem hiding this comment.
Looks to be a reasonable fix. .endsWith is not supported in IE, but since solid-ui uses Babel and since the data browser doesn't support IE anyway, I presume that's fine?
Good detective work!
Contributor
Author
|
Let's discuss the IE-thing on the upcoming standup. We need to document this somewhere as well. |
timbl
approved these changes
Aug 15, 2019
Contributor
timbl
left a comment
timbl
left a comment
There was a problem hiding this comment.
Looks good to me .. good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of ACL for root failed because the URI to PUT the file to contained an extra slash (e.g.
https://test.com//foo.txtinstead ofhttps://test.com/foo.txt). This was an error that also happens when trying to upload files elsewhere, but it was allowed then.This should fix SolidOS/solid-panes#143