Do not prefill a value for a checkbox #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megoth
approved these changes
Aug 15, 2019
timbl
approved these changes
Aug 16, 2019
Contributor
timbl
left a comment
timbl
left a comment
There was a problem hiding this comment.
Looks good to me.. we walked through the code in the failure state. Still not very easy code to wrap your head around
Contributor
|
I'll fix a new version that does not conflict with master and then merge it ^_^ |
If the BooleanField in the given resource is not set, the tristate logic would set it to false by default. This commit changes that to differentiate between the value that is shown (false), and the value that's actually present on the web.
megoth
force-pushed
the
fix/booleanfield
branch
from
dc9ed66 to
9a4046d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the BooleanField in the given resource is not set, the tristate
logic would set it to false by default. This commit changes that to
differentiate between the value that is shown (false), and the
value that's actually present on the web.
These changes were made as per Tim's instructions. They came up when working on SolidOS/solid-panes#144.