Skip to content

Prevent users from deleting their root ACLs #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Prevent users from deleting their root ACLs #96

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e75af0b
Prevent users from deleting their root ACLs
megoth Aug 19, 2019
1bf0647
Adding comment about the part that is hacky
megoth Aug 19, 2019
af8cd60
Added URL that might fix hack and remove eslint-disable-next-line
megoth Aug 22, 2019
d817ed9
Writing out use of window.location
megoth Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/acl-control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,14 +612,21 @@ UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) {
var q = str.indexOf('//')
var targetDocDir = ((q >= 0 && p < q + 2) || p < 0) ? null : str.slice(0, p + 1)

if (targetDocDir) {
// @@ TODO: The methods used for targetIsStorage are HACKs - it should not be relied upon, and work is
// @@ underway to standardize a behavior that does not rely upon this hack
// @@ hopefully fixed as part of https://github.com/solid/data-interoperability-panel/issues/10
const targetIsStorage = kb.holds(targetDoc, UI.ns.rdf('type'), UI.ns.space('Storage'), targetACLDoc)
const targetAclIsProtected = hasProtectedAcl(targetDoc)
const targetIsProtected = targetIsStorage || targetAclIsProtected

if (!targetIsProtected && targetDocDir) {
UI.acl.getACLorDefault($rdf.sym(targetDocDir), function (ok2, p22, targetDoc2, targetACLDoc2, defaultHolder2, defaultACLDoc2) {
if (ok2) {
prospectiveDefaultHolder = p22 ? targetDoc2 : defaultHolder2
}
addDefaultButton(prospectiveDefaultHolder)
})
} else {
} else if (!targetIsProtected) {
addDefaultButton()
}

Expand Down Expand Up @@ -685,4 +692,10 @@ UI.aclControl.ACLControlBox5 = function (subject, dom, noun, kb, callback) {
renderBox()
return table
} // ACLControlBox

function hasProtectedAcl (targetDoc) {
// @@ TODO: This is hacky way of knowing whether or not a certain ACL file can be removed
// Hopefully we'll find a better, standardized solution to this - https://github.com/solid/specification/issues/37
return targetDoc.uri === targetDoc.site().uri
}
// ends