Skip to content

check only for undefined description #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

check only for undefined description #23

merged 1 commit into from
Aug 19, 2021

Conversation

@bourgeoa
Copy link
Contributor

@bourgeoa bourgeoa commented Jul 31, 2021

!desc covers undefined and zero length string.
The test should only cover undefined

SharonStrats
SharonStrats approved these changes Aug 18, 2021
View reviewed changes
Copy link

@SharonStrats SharonStrats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bourgeoa !

@bourgeoa bourgeoa merged commit 72eaaf3 into main Aug 19, 2021
@bourgeoa bourgeoa deleted the desc_undefined branch August 19, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SharonStrats SharonStrats SharonStrats approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bourgeoa @SharonStrats