Fix flakes in tests using freeAddress
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the following error: ``` time=2025-11-14T16:14:59.573Z level=ERROR source=main.go:559 msg="Listen error" err="listen tcp 127.0.0.1:36357: bind: address already in use" ``` `freeAddress` is called multiple times within one test, but also in parallel in multiple tests. `freeAddress` immediately releases the port despite it being used later in a test. This causes ports to errorenously to be reused. We replace `net.Listen` in order to avoid calling `syscall.Listen`. This way the port can be reused by AM, without the kernel assuming that port can be reused by other processes specifiying port `0`. Fixes: prometheus#4742 Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
SoloJacobs
force-pushed
the
main
branch
3 times, most recently
from
ee148b2 to
154ef66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the following error:
freeAddressis called multiple times within one test, but also in parallel in multiple tests.freeAddressimmediately releases the port despite it being used later in a test. This causes ports to errorenously to be reused.We replace
net.Listenin order to avoid callingsyscall.Listen. This way the port can be reused by AM, without the kernel assuming that port can be reused by other processes specifiying port0.Fixes: prometheus#4742