Flake8 support#1
Closed
mshytikov wants to merge 11 commits intoSonarSource:masterfrom
mshytikov:flake8
Closed
Conversation
Contributor
|
Even if it is not a PR, let me comment it ;) I think the pylint-sensor implementation is not worth copying: a couple of years of experience building Sonar plugins has shown, that triggering external commands from the plugin is not the best idea. If flake 8 can produce machine-readable reports (json, xml, whatever) then "creating & feed report"-strategy is a much better one. |
Contributor
|
As we don't have plans in Flake8 support i'm closing PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This is not a pull request, but just a proof of concept
In our company we prefer to use
flake8overpylintand as a workaround I have created a 'copy-pasted' solution to add theflake8support to thesonar-python. So now it support both - flake8 and pylint.It work's for us. The jar with changes can be downloaded here.
Btw. It would be nice to have 'Issues' for the
sonar-pythonproject on github.Regards,
Max