Skip to content

Flake8 support#1

Closed
mshytikov wants to merge 11 commits intoSonarSource:masterfrom
mshytikov:flake8
Closed

Flake8 support#1
mshytikov wants to merge 11 commits intoSonarSource:masterfrom
mshytikov:flake8

Conversation

@mshytikov
Copy link
Copy Markdown

Hi

This is not a pull request, but just a proof of concept

In our company we prefer to use flake8 over pylint and as a workaround I have created a 'copy-pasted' solution to add the flake8 support to the sonar-python. So now it support both - flake8 and pylint.

It work's for us. The jar with changes can be downloaded here.

Btw. It would be nice to have 'Issues' for the sonar-python project on github.

Regards,
Max

@wenns
Copy link
Copy Markdown
Contributor

wenns commented Jun 4, 2014

Even if it is not a PR, let me comment it ;)

I think the pylint-sensor implementation is not worth copying: a couple of years of experience building Sonar plugins has shown, that triggering external commands from the plugin is not the best idea. If flake 8 can produce machine-readable reports (json, xml, whatever) then "creating & feed report"-strategy is a much better one.

@vilchik-elena
Copy link
Copy Markdown
Contributor

As we don't have plans in Flake8 support i'm closing PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants