Annotations are just partially saving (Windows)

[miiranta]

Summary

(Improvement)
The last annotations i saved are not loaded when i open Edit Annotations again.

(Bug)
When i manually load the annotations file in the Load Annotations field, the annotations are NOT loaded correctly; Some slides the title and description are missing; some they were preserved; The annotations itself seem to be saved correctly.

Steps to reproduce

(Bug)

1. Opening the Edit Annotations
2. Adding some Titles and Descriptions
3. Saving annotations
4. Closing the Edit Annotations window
5. Then opening again the Edit Annotations window

Environment

Slicer 5.11.0
Windows 10
Tutorial Maker version: 960d1f3 (main) -
Merge pull request #117 from SlicerLatinAmerica/hotfix-imagesize-mac

[DouSam]

(Improvement) The last annotations i saved are not loaded when i open Edit Annotations again.

It's better for us when the user opens the annotator, we show a box so he can select "Want to continue to edit the last annotations?" and then open the annotations or not. If we automatically load the annotations, the user can face the same problem if he doesn't want to continue to edit, and then we will have to delete all the annotations to continue to work.

[DouSam]

Also, always add screenshots. I know it's simple and easy to reproduce, but screenshots confirm where the error occurs.

[LuskasHusty]

There are some quirks that need to be fixed so that a loading operation is consistent without having to make some preparations first:

When a tutorial is first captured, it creates the raw captures of all of the steps and windows and saves them temporarily, when you run another tutorial those files get replaced.
When the annotator tries to make a load operation it fetches the raw contents, so to make sure a load is successful you need to have the tutorial captured already.
We do not want to save the screenshots as they are language specific, so the solution here is a popup asking the user if they want to try and run the capture script for the tutorial being loaded.

Only when the annotator saves a tutorial, it creates a merged version of screenshots that have multiple windows and saves them to the "Annotations" folder ready for the html generation process. It is also replaced if another tutorial is saved in the mean time
When a tutorial is loaded it expects these files to be already created. So a way to make sure the load process works as expected for the first time loading that tutorial is to open the annotator, save annotations then load the annotations.
Possible fix for this includes generating the merged version when opening the annotator, or when loading a annotation. Another one is getting rid of the saved merged version and always generate them when they are needed.
Being able to save the tutorial annotations wherever we want would fix this in theory and should be implemented, but we want the annotations themselves to be portable and independent of the language specific screenshots, so we also need one of the previous fixes

[miiranta]

Another important factor i found: it just happens if a previous version of annotations.json doesn't exist

1. So delete annotations.json

2. In the first slice you filled Title and Description with AAA, in the second with BBB, the third CCC.

3. Then, save, close the Edit window, open it again

4. Before loading, select the third slide (the one with CCC), then load it

See that CCC is gone

[miiranta]

It might be related to another bug i found: if you select a slide, then use the load option, the Title/Description of the slide selected is not updated on the screen. But generally if you select another slide and reopen the previous one the data appears

[LuskasHusty]

These are not related @miiranta to the main issue, please refer to my previous comment. The other factors you mentioned are a update order issue, where the slides are already open with empty fields and overwrite the loaded values.

[miiranta]

Well, related or not, both fixed in #132

[LuskasHusty]

Good job, please don't close this issue yet as loading is still not completely fixed.

[miiranta]

Ok. What problems do we still have during loading?