Skip to content

Conversation

@Crim
Copy link
Collaborator

@Crim Crim commented Jan 29, 2019

Adds the ability to communicate with SSL enabled Kafka-Connect REST services.

SSL certificates can be validated by:

  • Certificate added to JVM's TrustStore.
  • TrustStore JKS provided to client Configuration.
  • Certificate validation disabled.

@Crim Crim requested a review from stanlemon January 29, 2019 05:23
Copy link

@kevpeek kevpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

/**
* Skip all validation of SSL Certificates. This is insecure and highly discouraged!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps log a warning that this is not a good configuration.

@Crim Crim merged commit f64b161 into master Jan 30, 2019
@Crim Crim deleted the sp/sslClient branch January 30, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants