Skip to content

[DIA-5989] loadMessage() without authId : fix for ios #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andresilveirah merged 2 commits into from
Sep 17, 2025
Merged

[DIA-5989] loadMessage() without authId : fix for ios #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dc9cf1
fix for ios
Nevazhnovu Sep 16, 2025
0a73215
review fix
Nevazhnovu Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NativeReactNativeCmp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export interface Spec extends TurboModule {
options?: SPBuildOptions,
): void;
getUserData(): Promise<SPUserData>;
loadMessage(params?: LoadMessageParams): void;
loadMessage(params: LoadMessageParams): void;
clearLocalData(): void;
loadGDPRPrivacyManager(pmId: string): void;
loadUSNatPrivacyManager(pmId: string): void;
Expand Down
2 changes: 1 addition & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default class SPConsentManager implements Spec {
return ReactNativeCmp.getUserData();
}

loadMessage(params?: LoadMessageParams) {
loadMessage(params: LoadMessageParams = { authId: undefined }) {
ReactNativeCmp.loadMessage(params);
}
Copy link
Member

@andresilveirah andresilveirah Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nevazhnovu I think we can simplify this using default params:

loadMessage(params: LoadMessageParams = { authId: undefined }) {
  ReactNativeCmp.loadMessage(params);
}

Can you give it a try? Check if users can still call loadMessage() (without params).

Copy link
Collaborator Author

@Nevazhnovu Nevazhnovu Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresilveirah it works! Just have pushed a fix


Expand Down
Loading