Skip to content

Conversation

@kalnik-a-a
Copy link
Contributor

No description provided.

return createTransmission(conn, numRcptErrors, trans);
}

public static TransmissionCreateResponse create(RestConnection conn, Integer numRcptErrors, TransmissionWithRecipientList trans) throws SparkPostException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of two methods we could just use TransmissionBase. Do you think it is better to overload the method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a comment about this into issue

2016-04-14 22:58 GMT+03:00 Chris Wilson notifications@github.com:

In
libs/sparkpost-lib/src/main/java/com/sparkpost/resources/ResourceTransmissions.java
#41 (comment)
:

@@ -22,6 +24,16 @@

 public static TransmissionCreateResponse create(RestConnection conn, Integer numRcptErrors, TransmissionWithRecipientArray trans) throws SparkPostException {
  •    return createTransmission(conn, numRcptErrors, trans);
    
  • }
  • public static TransmissionCreateResponse create(RestConnection conn, Integer numRcptErrors, TransmissionWithRecipientList trans) throws SparkPostException {

I think instead of two methods we could just use TransmissionBase. Do you
think it is better to overload the method?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SparkPost/java-sparkpost/pull/41/files/7cd1ad9ec2d5275c9f32e83ab339a39340fafd50#r59780860

С уважением, Кальник Александр.

@yepher yepher merged commit 37fd279 into SparkPost:master Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants