Add php-cs-fixer as composer script and make initial fix-style run #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jasonrhodes has anyone reviewed this yet? |
Contributor
|
@richleland - nobody has. I can. |
lib/SparkPost/APIResource.php
Outdated
|
|
||
| $url = $this->buildUrl($resourcePath, $options); | ||
| $body = $this->buildBody($options); | ||
| $body = $this->buildBody($options); |
Contributor
There was a problem hiding this comment.
I like most of what has been done here but I don't think that it handled the spaces to tabs thing very well. These 3 lines end up having $action and $body both indented farther than $url
Contributor
|
So, I'm noticing that spacing issue a lot. The PSR-2 standard says:
Looks like we're going to have to fix that one by hand. |
Contributor
|
What's next? Want me to go through and fix the space/tabs thing? |
Contributor
|
Sure, I was thinking about scriptifying it so that this cs-fixer and that script could be ran easily. Sort of like our linting stuff for other projects. Just haven't had time to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get a few eyes on this to make sure it looks ok, but this will make style stuff way easier imo.