Skip to content

Support attachments #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2016
Merged

Support attachments #50

merged 1 commit into from
Mar 10, 2016

Conversation

@zaporylie
Copy link
Contributor

@zaporylie zaporylie commented Mar 8, 2016

Additional mapping in Transmission::$parameterMappings to support attachments.

@artembochkov
Copy link

artembochkov commented Mar 9, 2016

Thanks for your commit, you've saved me a day.
I'd suggest you also add missing support for inline-images:
/lib/SparkPost/Transmission.php

  • 'inlineImages'=>'content.inline_images',

👍

@zaporylie
Copy link
Contributor Author

zaporylie commented Mar 9, 2016

Maybe just create another issue/PR to support inline images?

@chandon
Copy link
Contributor

chandon commented Mar 10, 2016

I did PR #53 for inline_images

richleland added a commit that referenced this pull request Mar 10, 2016
@richleland
Merge pull request #50 from zaporylie/bug/missing-attachments
3ad7c14 
Support attachments
@richleland richleland merged commit 3ad7c14 into SparkPost:master Mar 10, 2016
@richleland
Copy link
Contributor

richleland commented Mar 10, 2016

Thanks for the contribution @zaporylie - tested and it works like a charm.

@zaporylie zaporylie mentioned this pull request Mar 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zaporylie @artembochkov @chandon @richleland