Improve APIResponseException class #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
| * Gets the Exception message | ||
| * @return string the Exception message as a string. | ||
| */ | ||
| public function getAPIMessageDescription() { |
Contributor
There was a problem hiding this comment.
For consistency with the field names from the API, what do you think about calling this method getAPIDescription?
Contributor
|
Hi @zaporylie this PR looks great - can we get the methods on the exception class covered? https://coveralls.io/builds/5351334/source?filename=lib%2FSparkPost%2FAPIResponseException.php |
Contributor
Author
|
Renamed |
richleland
added a commit
that referenced
this pull request
Mar 14, 2016
…eption Improve APIResponseException class
Contributor
|
Thanks for the contribution @zaporylie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I work on SparkPost module for Drupal. I had some troubles sending email and Exception message and Code doesn't really help to investigate what was the source of the problem. API response has quite nice error message handling so I've added arguments to APIResponseException definition to aggregate API error messages.
__construct($message = "", $code = 0, $apiMessage = "", $apiCode = 0, $apiMessageDescription = "")where
$messageis custom message,$codeis HTTP status Code,$apiMessageis API error message received from endpoint,$apiCodeis API error code received from endpoint,$apiMessageDescriptionis API error message description received from endpoint.Nothing special but it should improve DX, fix #44 and is backward compatible.