Skip to content

Conversation

@lordross
Copy link

No description provided.

Rosen Nedyalkov added 4 commits November 21, 2014 19:39
src/ds3.c Outdated
}
else {
error->error->error_body = ds3_str_init("(empty)");
}
Copy link
Contributor

@DenverM80 DenverM80 Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks old. This method was moved to ds3_net.c - are you still seeing an issue with it?

It has been changed to:

34 <   if (response_data.status_code < 200 || response_data.status_code >= 300) {
535 <       ds3_error* error = ds3_create_error(DS3_ERROR_BAD_STATUS_CODE, "Got an unexpected status code.");
536 <       error->error = g_new0(ds3_error_response, 1);
537 <       error->error->http_error_code = response_data.status_code;
538 <       error->error->code = ds3_str_init(response_data.status_message->value);
539 <       if (response_data.body != NULL) {
540 <           error->error->message = ds3_str_init_with_size((char*)response_data.body->data, response_data.bod>
541 <           g_byte_array_free(response_data.body, TRUE);
542 <       } else {
543 <           ds3_log_message(client->log, DS3_ERROR, "The response body for the error is empty");
544 <           error->error->message = NULL;
545 <       }
546 <       ds3_string_multimap_free(response_headers);
547 <       ds3_str_free(response_data.status_message);
548 <       g_free(url);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Probably it must have slipped in the master branch in our clone repo. Please omit this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It doesn't show up in the overall diff, so we are fine there just wanted to confirm.

@rpmoore rpmoore merged commit 64c3b6a into SpectraLogic:master Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants