Update to BP 3.5.0 API; Improve const correctness for parameters #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpmoore
suggested changes
Apr 19, 2017
| LIBRARY_API ds3_error* ds3_verify_safe_to_create_put_job_spectra_s3_request(const ds3_client* client, const ds3_request* request); | ||
| LIBRARY_API ds3_request* ds3_init_get_node_spectra_s3_request(const char* resource_id); | ||
| LIBRARY_API ds3_request* ds3_init_get_node_spectra_s3_request(const char *const resource_id); | ||
| LIBRARY_API ds3_error* ds3_get_node_spectra_s3_request(const ds3_client* client, const ds3_request* request, ds3_node_response** response); |
Contributor
There was a problem hiding this comment.
Should the client in this case also be const?
rpmoore
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** No errors detected
==9120==
==9120== HEAP SUMMARY:
==9120== in use at exit: 91,618 bytes in 17 blocks
==9120== total heap usage: 4,660,224 allocs, 4,660,207 frees, 2,942,534,707 bytes allocated
==9120==
...
==9120== LEAK SUMMARY:
==9120== definitely lost: 0 bytes in 0 blocks
==9120== indirectly lost: 0 bytes in 0 blocks
==9120== possibly lost: 0 bytes in 0 blocks
==9120== still reachable: 91,618 bytes in 17 blocks
==9120== suppressed: 0 bytes in 0 blocks
==9120==
==9120== For counts of detected and suppressed errors, rerun with: -v
==9120== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
[100%] Built target mem