Print unsigned long long Platform independent #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraciesPadre
approved these changes
Jul 11, 2017
Contributor
GraciesPadre
left a comment
GraciesPadre
left a comment
There was a problem hiding this comment.
I'm wondering if glib uses the safe string version of functions like g_snprintf? If it doesn't, we probably ought to look into a cross-platform string library that uses the platform-supplied safe string functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio is apparently C89 compliant, so a few changes were needed to make printing of uint64_t work correctly.
Added tests to verify we are able to set the max offset size for a put_object request, and fixed a regression in the create folder test where we free'd a struct too early.