Fixing marshaling of ids request payload #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpmoore
suggested changes
Mar 29, 2018
src/ds3_test_exports.h
Outdated
|
|
||
| // For windows unit test symbol exports. | ||
| #ifdef _WIN32 | ||
| # ifdef TEST_EXPORTS |
src/CMakeLists.txt
Outdated
| ds3_bool.h | ||
| ds3_library_exports.h) | ||
| ds3_library_exports.h | ||
| ds3_test_exports.h) |
Contributor
There was a problem hiding this comment.
I believe the marshaling header needs to be added here.
src/ds3_marshaling.h
Outdated
| size_t total_read; | ||
| }ds3_xml_send_buff; | ||
|
|
||
| TEST_API xmlDocPtr ds3_generate_xml_ids(ds3_ids_list* ids_list); |
Contributor
There was a problem hiding this comment.
Why do we need to add this macro to these calls?
rpmoore
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes