Fix integration tests #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenverM80
approved these changes
Sep 27, 2016
Contributor
DenverM80
left a comment
DenverM80
left a comment
There was a problem hiding this comment.
Looks good. This should resolve the inconsistencies between test ordering.
|
|
||
| } finally { | ||
| FileUtils.deleteDirectory(tempDirectory.toFile()); | ||
| deleteBigFile(); |
Contributor
There was a problem hiding this comment.
This will delete the file from BUCKET_NAME, but wasn't the file placed in DIR_NAME in this test?
| } | ||
| } finally { | ||
| FileUtils.deleteDirectory(tempDirectory.toFile()); | ||
| deleteBigFile(); |
Contributor
There was a problem hiding this comment.
Same question as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests started to fail after correcting for resource files that had Windoze line endings. The fix is to use the file system to tell us how big the resource file is and to have the resource file we compare to use \n as line ending and whose content is determined from an origin file with \n line endings.
Also fixed a couple tests that weren't cleaning up after themselves.