Read retry bug fix #400
Merged
Read retry bug fix #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject retry logic from retrying.
…rs to use instead of catching an exception when a read job fails.
rpmoore
suggested changes
Dec 12, 2016
| final Collection<String> objectNames) | ||
| throws IOException | ||
| { | ||
| final Map<String, Long> objectSizeMap = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
Is this map going to be mutated? If not convert this to an ImmutableMap and use the ImmutableMap.Builder to create it.
|
|
||
| long requiredSpace = 0; | ||
| long availableSpace = 0; | ||
| final IOException ioException = null; |
Contributor
There was a problem hiding this comment.
Is this purposefully alway null?
| helpers.ensureBucketExists(bucketName); | ||
| } catch (final IOException e) { | ||
| return new ObjectStorageSpaceVerificationResult(ObjectStorageSpaceVerificationResult.VerificationStatus.BucketDoesNotExist, | ||
| requiredSpace, availableSpace, ioException); |
Contributor
There was a problem hiding this comment.
Is e supposed to be passed in instead of ioException
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class UnrecoverableIOException extends IOException { |
Contributor
There was a problem hiding this comment.
Add an explanation of what an unrecoverable IO Exception is.
rpmoore
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://jira.spectralogic.com/browse/JSDK-185.
There are 2 parts:
Read jobs are refactored so that failures in writing a file short-circuit the read retry logic and bubble an exception back to the client.
Implements a helper function that allows customer to see if the objects they want to get from a BP bucket will fit in a directory they tell us about, instead of relying on catching an exception during the read.