Removed the Closeable from Ds3Response. #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2014 16:45
The only response that actually needed to be closed was the GetObject and even it no longer needs closing. So I've removed the Closeable implementation from the Ds3Response and made sure to clean up the response in each response parsing method.
* Updated the integration tests so they don't close DS3 responses. * Updated the integration tests to use the ObjectChannelBuilder.
Contributor
Author
|
I've updated the samples and the readme. |
rpmoore
added a commit
that referenced
this pull request
Sep 17, 2014
Removed the Closeable from Ds3Response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only response that actually needed to be closed was the GetObject
and even it no longer needs closing. So I've removed the Closeable
implementation from the Ds3Response and made sure to clean up the
response in each response parsing method.