Skip to content

SDKPM-45: Unit tests validating request payloads #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rpmoore merged 1 commit into from
Aug 11, 2017
Merged

SDKPM-45: Unit tests validating request payloads #493

rpmoore merged 1 commit into from
Aug 11, 2017

Conversation

@RachelTucker
Copy link
Contributor

@RachelTucker RachelTucker commented Aug 11, 2017

Changes

  • Created a unit test for all requests that have payloads (excluding any that already had sufficient tests)
  • Added secondary constructor to CompleteMultipartUpload and Part models (non-generated) to improve usability. Note that basic constructors are used in marshaling/unmarshaling.

@rpmoore rpmoore merged commit 4588c4e into SpectraLogic:master Aug 11, 2017
@RachelTucker RachelTucker deleted the SDKPM-45-validation-tests branch August 11, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpmoore rpmoore rpmoore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RachelTucker @rpmoore