Java 8 and kotlin #504
Merged
Java 8 and kotlin #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of gradle. Updated the listObjectsForDirectory helper method to be lazy. Updated the start_job commands to fully pass the Iterable along instead of copying it to a List. Added a paginated bucket delete call that minimizes the number of API calls that are used to delete all the objects in a bucket. Fixed an issue in the payload generation of the bulk request body to work around an issue when trying to serialize the payload from an Iterable. Updated the version of Jackson.
…rsion information into a single file. Fixed a bug in the network code introduced by reving the http client version.
…to make the service loader work correctly as well.
…the same variable
…re excluding the ds3-interfaces and ds3-utils projects from the metadata build since those classes must be included as apart of the ds3-sdk project, and will already exist.
…s. Performing some minor code cleanup
| @@ -0,0 +1,28 @@ | |||
| package com.spectralogic.ds3client.utils.collections; | |||
| @@ -0,0 +1,23 @@ | |||
| package com.spectralogic.ds3client.helpers | |||
| return StreamWrapper.wrapStream(Files.walk(startDir).map { | ||
| Ds3Object(startDir.relativize(it).toString().replace("\\", "/"), Files.size(it)) | ||
| }.filter { | ||
| !Guard.isStringNullOrEmpty(it.name) // skip entries that are null or are the empty string |
Contributor
There was a problem hiding this comment.
Since this is kotlin, why not just ! it.name.isNullOrEmpty()?
Contributor
Author
There was a problem hiding this comment.
I didn't realize kotlin had that. Updating...
|
|
||
| walk.forEach { | ||
| listBuilder.add(it) | ||
| println(it.name) |
Contributor
There was a problem hiding this comment.
Log, as opposed to println()?
Contributor
Author
There was a problem hiding this comment.
Opps. That was a debug print. I'll remove
GraciesPadre
approved these changes
Aug 29, 2017
Contributor
GraciesPadre
left a comment
GraciesPadre
left a comment
There was a problem hiding this comment.
Looks OK to me, aside from a couple nits. I'll leave it form someone else to merge, so we all get a chance to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following:
gradle.propertiesfile