Version id in payload #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names are not unique, but the UUID's are. Add versionId to DeleteObjectsError.
rpmoore
suggested changes
Apr 5, 2018
| } | ||
| else | ||
| { | ||
| for ( UUID versionId : entry.getValue() ) |
| for(final String objName : objects) { | ||
| deleteObjects.add(new DeleteObject(objName)); | ||
|
|
||
| for ( Map.Entry< String, Set< UUID > > entry : objects.entrySet() ) |
| private static List<String> contentsToString(final Iterable<Contents> objs) { | ||
| final List<String> objKeyList = new ArrayList<>(); | ||
|
|
||
| private static Map< String, Set< UUID > > contentsToString( final Iterable< Contents > objs ) |
Contributor
There was a problem hiding this comment.
You deleted the constructor this code was used in. I believe this code is now dead. If so, it should be removed.
Contributor
Author
There was a problem hiding this comment.
I wasn't sure, removed now.
build.gradle
Outdated
| allprojects { | ||
| group = 'com.spectralogic.ds3' | ||
| version = '3.2.8-COMPAT-2' | ||
| version = '3.2.8-SNAPSHOT-3' |
Contributor
There was a problem hiding this comment.
You should update the version number back to COMPAT.
rpmoore
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add versionId to DeleteObject, DeleteObjectsRequest and DeleteObjectError.