JSDK-285: Updating get job transfer methods to add version id when getting object #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RachelTucker
commented
May 4, 2018
RachelTucker
commented
- Added version ID to helper get job transfer methods
- Added util in test for deleting all buckets and their contents because I didn't want to manually delete 100+ buckets manually when the cascade failure happened due to BP bug.
rpmoore
suggested changes
May 4, 2018
| final GetBucketsSpectraS3Request request = new GetBucketsSpectraS3Request(); | ||
| final GetBucketsSpectraS3Response response = client.getBucketsSpectraS3(request); | ||
|
|
||
| for (Bucket bucket : response.getBucketListResult().getBuckets()) { |
Contributor
|
Unit tests are failing. |
Contributor
Author
|
I ran the integration tests, but didn't think about the unit tests. probably something to do with mocks. Will fix. |
rpmoore
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.