PYTHONSDK-97: Add functionality to specify a directory in put data call #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll. Implemented basic streaming strategy helpers. Fixed miscelaneous errors, including incorrectly performing a file path normalization on object names in bulk put and get request payloads.
shabtaisharon
approved these changes
Mar 30, 2021
Contributor
shabtaisharon
left a comment
shabtaisharon
left a comment
There was a problem hiding this comment.
LGTM, I am not a python expert but you have my blessing :)
bensont
approved these changes
Mar 30, 2021
| self.offset = offset | ||
|
|
||
| def __eq__(self, other): | ||
| if self.name == other.name and self.length == other.length and self.offset == other.offset: |
Collaborator
There was a problem hiding this comment.
I'm not sure this is necessary. The variables sent to init have their types specified. The types aren't explicitly set for "other". You might want to use === because that checks both the value and the data type.
Edit: after reviewing all the code, it appears that the "other" field types are set before each call, so this is probably okay. Your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous Bug fixes: