Skip to content

Make exceptions a bit more informative #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 25, 2020
Merged

Make exceptions a bit more informative #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e714cb
Add entity class name to the thrown exception
yuri-sergiichuk Mar 25, 2020
d1e1ab2
Add the command ID value to the exception message.
yuri-sergiichuk Mar 25, 2020
e933122
Add more debug information to the exception
yuri-sergiichuk Mar 25, 2020
03c34e9
Add the message itself to provide more context in the exception
yuri-sergiichuk Mar 25, 2020
7421f03
Pull latest config module
yuri-sergiichuk Mar 25, 2020
4ffe82d
Bump version
yuri-sergiichuk Mar 25, 2020
8d370a6
Fix the review comments
yuri-sergiichuk Mar 25, 2020
34880a1
Use the class canonical name
yuri-sergiichuk Mar 25, 2020
565875b
Add missing parameter
yuri-sergiichuk Mar 25, 2020
375fd74
Remove the obsolete placeholder.
yuri-sergiichuk Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions .idea/inspectionProfiles/Project_Default.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config
Open in desktop
Submodule config updated 4 files
+2 −1 gradle/dependencies.gradle
+11 −21 gradle/js/build-tasks.gradle
+219 −0 gradle/update-gh-pages.gradle
+4 −0 scripts/register-ssh-key.sh
32 changes: 16 additions & 16 deletions license-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@


# Dependencies of `io.spine:spine-client:1.5.3`
# Dependencies of `io.spine:spine-client:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -415,12 +415,12 @@
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:12 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:14 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine:spine-core:1.5.3`
# Dependencies of `io.spine:spine-core:1.5.4`

## Runtime
1. **Group:** com.google.code.findbugs **Name:** jsr305 **Version:** 3.0.2
Expand Down Expand Up @@ -791,12 +791,12 @@ This report was generated on **Mon Mar 23 17:33:12 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:13 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:15 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.tools:spine-model-assembler:1.5.3`
# Dependencies of `io.spine.tools:spine-model-assembler:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -1206,12 +1206,12 @@ This report was generated on **Mon Mar 23 17:33:13 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:13 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:15 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.tools:spine-model-verifier:1.5.3`
# Dependencies of `io.spine.tools:spine-model-verifier:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -1681,12 +1681,12 @@ This report was generated on **Mon Mar 23 17:33:13 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:14 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:17 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine:spine-server:1.5.3`
# Dependencies of `io.spine:spine-server:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -2113,12 +2113,12 @@ This report was generated on **Mon Mar 23 17:33:14 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:14 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:18 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine:spine-testutil-client:1.5.3`
# Dependencies of `io.spine:spine-testutil-client:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -2586,12 +2586,12 @@ This report was generated on **Mon Mar 23 17:33:14 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:15 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:20 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine:spine-testutil-core:1.5.3`
# Dependencies of `io.spine:spine-testutil-core:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -3067,12 +3067,12 @@ This report was generated on **Mon Mar 23 17:33:15 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:16 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:21 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine:spine-testutil-server:1.5.3`
# Dependencies of `io.spine:spine-testutil-server:1.5.4`

## Runtime
1. **Group:** com.google.android **Name:** annotations **Version:** 4.1.1.4
Expand Down Expand Up @@ -3584,4 +3584,4 @@ This report was generated on **Mon Mar 23 17:33:16 EET 2020** using [Gradle-Lice
The dependencies distributed under several licenses, are used according their commercial-use-friendly license.


This report was generated on **Mon Mar 23 17:33:18 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Wed Mar 25 18:42:25 EET 2020** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ all modules and does not describe the project structure per-subproject.

<groupId>io.spine</groupId>
<artifactId>spine-core-java</artifactId>
<version>1.5.3</version>
<version>1.5.4</version>

<inceptionYear>2015</inceptionYear>

Expand Down
7 changes: 4 additions & 3 deletions server/src/main/java/io/spine/server/aggregate/AggregateRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ private Optional<MirrorRepository> mirrorRepository() {
*/
protected AggregateStorage<I> aggregateStorage() {
@SuppressWarnings("unchecked") // We check the type on initialization.
AggregateStorage<I> result = (AggregateStorage<I>) storage();
AggregateStorage<I> result = (AggregateStorage<I>) storage();
return result;
}

Expand Down Expand Up @@ -616,8 +616,9 @@ protected A play(I id, AggregateHistory history) {
tx.commitIfActive();
if (!success) {
lifecycleOf(id).onCorruptedState(outcome);
throw newIllegalStateException("Aggregate %s (ID: %s) cannot be loaded.%n",
aggregateClass().value().getName(),
throw newIllegalStateException("Aggregate `%s` (ID: %s) cannot be loaded.%n",
aggregateClass().value()
.getName(),
result.idAsString());
}
return result;
Expand Down
6 changes: 5 additions & 1 deletion server/src/main/java/io/spine/server/commandbus/CommandAckMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ private static EventMessage systemEventFor(Status status, CommandId commandId) {
.build();
case REJECTION:
default:
throw newIllegalArgumentException("Invalid status %s.", status.getStatusCase());
throw newIllegalArgumentException(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this error popped up in your log? If so, this is a bug or a compatibility issue worth paying attention to. Let's discuss if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not really. I looked over the other messages that could have a bit more useful info.

"Command `%s` has invalid status `%s`.",
commandId.getUuid(),
status.getStatusCase()
);
}
}

Expand Down
Loading