Skip to content

Improve error messages #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Improve error messages #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions testutil-server/src/main/java/io/spine/testing/server/blackbox/DiagnosticLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,17 @@ private DiagnosticLog() {

@Subscribe
void on(ConstraintViolated event) {
String typeUrl = event.getEntity()
.getTypeUrl();
String idAsString = Identifier.toString(event.getEntity().getId());
log(event, "Entity state (ID: `%s`, type: `%s`) is invalid.", idAsString, typeUrl);
MessageId entity = event.getEntity();
String typeUrl = entity.getTypeUrl();
String idAsString = Identifier.toString(entity.getId());
log(event, "The state (type: `%s`) of the entity (ID: `%s`) is invalid.",
typeUrl, idAsString);
}

@Subscribe
void on(CannotDispatchDuplicateCommand event) {
MessageId command = event.getDuplicateCommand();
log(event, "Command `%s` (ID: `%s`) should not be dispatched twice.",
log(event, "The command `%s` (ID: `%s`) should not be dispatched twice.",
command.getTypeUrl(),
command.asCommandId()
.getUuid());
Expand All @@ -95,18 +96,18 @@ void on(CannotDispatchDuplicateEvent event) {

@Subscribe
void on(HandlerFailedUnexpectedly event) {
log(event, "Signal `%s` could not be handled by %s:%n%s%n",
event.getHandledSignal()
.getTypeUrl(),
log(event, "The entity (state type `%s`) could not handle the signal `%s`:%n%s%n",
event.getEntity()
.getTypeUrl(),
event.getHandledSignal()
.getTypeUrl(),
event.getError()
.getMessage());
}

@Subscribe
void on(RoutingFailed event) {
log(event, "Signal `%s` could not be routed to `%s`:%n%s%n",
log(event, "The signal `%s` could not be routed to `%s`:%n%s%n",
event.getHandledSignal()
.getTypeUrl(),
event.getEntityType()
Expand All @@ -119,7 +120,8 @@ void on(RoutingFailed event) {
void on(AggregateHistoryCorrupted event) {
MessageId aggregate = event.getEntity();
String idAsString = Identifier.toString(aggregate.getId());
log(event, "History of aggregate `%s` (ID: `%s`) could not be loaded:%n%s%n",
log(event,
"Unable to load the history of the aggregate (state type: `%s`, ID: `%s`):%n%s%n",
aggregate.getTypeUrl(),
idAsString,
event.getError()
Expand Down