Kotlin Gradle scripts #1278
Kotlin Gradle scripts #1278
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
============================================
- Coverage 91.11% 91.11% -0.01%
- Complexity 4696 4697 +1
============================================
Files 605 605
Lines 14921 14920 -1
Branches 852 852
============================================
- Hits 13596 13595 -1
Misses 1058 1058
Partials 267 267 |
|
@armiol, PTAL. |
build.gradle.kts
Outdated
|
|
||
| idea { | ||
| module { | ||
| generatedSourceDirs.add(file(generatedJavaDir)) |
There was a problem hiding this comment.
I assume they don't have addAll(), don't they?
| * A task which verifies that the current version of the library has not been published to the given | ||
| * Maven repository yet. | ||
| */ | ||
| open class CheckVersionIncrement : AbstractTask() { |
There was a problem hiding this comment.
Do we have to carry this with each of the repositories, or we can copy it over from config and not have it in the GitHub repo itself?
There was a problem hiding this comment.
We have to copy it because CI needs it as well. As a rule, we don't do pull on CI since config used in a repository may be older (intentionally) or use a non-master branch.
version.gradle.kts
Outdated
| */ | ||
|
|
||
| project.extra.apply { | ||
| this["spineBaseVersion"] = "1.5.12" |
There was a problem hiding this comment.
This is going to be pretty hard to parse from the auto-updating script.
Is there anything we could do to make it more object-oriented, maybe? Or less String-dependent?
|
@armiol, PTAL again. |
2 participants
In this PR we migrate all Gradle scripts to Kotlin.
We also start checking that the current version of the
corelibrary is not yet published to the Maven repository. As a rule, we only need to check one module per Git repository.