Improve custom environments support #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
============================================
+ Coverage 91.02% 91.06% +0.04%
- Complexity 4710 4715 +5
============================================
Files 606 606
Lines 15005 15009 +4
Branches 853 853
============================================
+ Hits 13658 13668 +10
+ Misses 1077 1074 -3
+ Partials 270 267 -3 |
|
@armiol PTAL. |
armiol
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
@dmitrykuzmin LGTM in general. Please reconsider the @Interal removal once again — see my comment on this matter.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1291.
Parts of the framework where the
Productionenvironment usage was hard-coded are changed to support the custom environment types.Please note, that the
Testsenvironment is still treated specially in some cases. For example, the parallel posting of system events is disabled for tests as some of them rely on the eventual consistency of the data.The library version advances to
1.5.25.