Add convenience wrapper for getting strings from ValueMismatch.
#191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.12% (diff: 50.00%)@@ master #191 diff @@
==========================================
Files 130 130
Lines 4701 4709 +8
Methods 0 0
Messages 0 0
Branches 518 518
==========================================
+ Hits 3672 3679 +7
- Misses 934 937 +3
+ Partials 95 93 -2
|
| public void return_mismatch_object_with_int32_values() { | ||
| final int expected = 0; | ||
| final int actual = 1; | ||
| final int requested = 2; |
Collaborator
There was a problem hiding this comment.
If we remove unnecessary 'requsted' code from class.
Maybe remove private static final String REQUESTED as well.
Contributor
Author
There was a problem hiding this comment.
Well spotted. Fixed.
dmytro-kashcheiev
requested changes
Oct 7, 2016
Collaborator
dmytro-kashcheiev
left a comment
dmytro-kashcheiev
left a comment
There was a problem hiding this comment.
This is very small change, see inline comment
Contributor
|
@alexander-yevsyukov LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.