Stand storage coverage improvement #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@armiol PTAL |
Current coverage is 81.71% (diff: 100%)
@@ stand-in-memory #196 diff @@
=================================================
Files 145 145
Lines 5382 5956 +574
Methods 0 0
Messages 0 0
Branches 592 724 +132
=================================================
+ Hits 4297 4867 +570
+ Misses 975 974 -1
- Partials 110 115 +5
|
armiol
reviewed
Oct 12, 2016
|
|
||
| protected abstract StandStorage createStorage(); | ||
|
|
||
| protected static final Supplier<AggregateStateId<ProjectId>> DEFAULT_ID_SUPPLIER = new Supplier<AggregateStateId<ProjectId>>() { |
Contributor
There was a problem hiding this comment.
Please check if this line fits 120 symbols.
armiol
requested changes
Oct 12, 2016
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov LGTM except for minor comments.
| @Override | ||
| public AggregateStateId<ProjectId> get() { | ||
| final ProjectId projectId = ProjectId.newBuilder() | ||
| .setId(UUID.randomUUID() |
Contributor
There was a problem hiding this comment.
Use Identifiers instead of UUID.randomUUID().toString().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover methods:
readAll()readMultiple(ids)