Add cleaning of EntityContext to EEntity
#581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
============================================
+ Coverage 92.74% 92.76% +0.01%
- Complexity 2693 2697 +4
============================================
Files 326 326
Lines 9290 9311 +21
Branches 615 616 +1
============================================
+ Hits 8616 8637 +21
Misses 494 494
Partials 180 180 |
alexander-yevsyukov
requested changes
Sep 19, 2017
Contributor
alexander-yevsyukov
left a comment
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my comments.
| eventStore.append(enriched); | ||
| final MemoizingObserver<Event> observer = memoizingObserver(); | ||
| eventStore.read(EventStreamQuery.getDefaultInstance(), observer); | ||
| final RejectionContext modifiedOrigin = observer.responses() |
Contributor
There was a problem hiding this comment.
What did you mean by modifiedOrigin? This question applies to this variable and similar below.
| final EventContext.Builder resultContext = context.toBuilder() | ||
| .clearEnrichment(); | ||
| final EventContext originEventContext = context.getEventContext(); | ||
| if (!isDefault(originEventContext)) { |
Contributor
There was a problem hiding this comment.
Please use case detection API from Protobuf.
alexander-yevsyukov
requested changes
Sep 19, 2017
Contributor
alexander-yevsyukov
left a comment
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please have default statement with ISE.
alexander-yevsyukov
requested changes
Sep 19, 2017
Contributor
alexander-yevsyukov
left a comment
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my comments.
| // Does nothing because the origins is `null`. | ||
| break; | ||
| default: | ||
| throw newIllegalStateException("Not all of `OriginCase` values were handled."); |
Contributor
There was a problem hiding this comment.
Have the message which says something like “Unsupported origin case encountered: %s”.
| break; | ||
| case ORIGIN_NOT_SET: | ||
| throw newIllegalStateException("EventContext.origin should be set."); | ||
| // Does nothing because the origins is `null`. |
Contributor
There was a problem hiding this comment.
Protofub doesn't have nulls. This comment is misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes work of
EventStore. Before,EventStorestored redundant data such as enrichments.Such a behavior could cause performance issues, especially after addition of
Reactannotation.Because
EventContext.originmay contain anotherEventContextand so on and so on. And everyEventContextmay contain information aboutEnrichmentof an event.So from now,
EEntitydoesn't contain data about the enrichment of the event (which the entity represents), enrichment of the origin (if the origin isEventContextorRejectionContext) and nested origins.