Implement overhaul of cause system by Deamon5550 · Pull Request #1208 · SpongePowered/Sponge

Deamon5550 · 2017-02-15T06:55:08Z

SpongeApi | SpongeCommon | SpongeForge | SpongeVanilla

See api PR for description

Current causes

Event	Bleeding	Now
GrantAchievementEvent	`Cause[{Name=Source, Object={EntityPlayerMP['Deamon_t'/293, l='world', x=-185.83, y=72.00, z=339.17]}]`	`Cause (size 1): [EntityPlayerMP['Deamon_t'/293, l='world', x=-185.83, y=72.00, z=339.17]] Context (0): []`

ryantheleach · 2017-07-19T07:39:06Z

I notice that you have a table in the original post, do you need help in dumping all the current causes ?

Or how can I assist with testing?

Deamon5550 · 2017-07-20T06:55:38Z

@ryantheleach yeah if you want to go through and dump current causes for bleeding that would be a great help

ryantheleach · 2017-07-21T06:37:39Z

src/main/java/org/spongepowered/common/mixin/core/entity/MixinEntityLivingBase.java

+            causeTracker.completePhase(EntityPhase.State.DEATH);
+        }
+
+        if (frame != null) {


Do these really pop up as often as I think they do? Frame.closeOnMainThread(frame)?

ryantheleach · 2017-07-21T06:38:07Z

src/main/java/org/spongepowered/common/mixin/core/entity/MixinEntityLivingBase.java

-            if (entity != null) {
-                entity.onKillEntity((EntityLivingBase) (Object) this);
+        final boolean isMainThread = !this.world.isRemote || Sponge.isServerAvailable() && Sponge.getServer().isMainThread();
+        final CauseStackFrame frame = isMainThread ? Sponge.getCauseStackManager().pushCauseFrame() : null;


Sponge.getCauseStackManager().pushFrameIfMain(); ?

Faithcaio · 2017-07-23T10:09:53Z

src/main/java/org/spongepowered/common/event/tracking/phase/tick/BlockTickPhaseState.java

-                            EntityUtil.toMixin(entity).setCreator(entityCreator.getUniqueId());
+        try (CauseStackFrame frame = Sponge.getCauseStackManager().pushCauseFrame()) {
+            Sponge.getCauseStackManager().pushCause(locatableBlock);
+            Sponge.getCauseStackManager().addContext(EventContextKeys.SPAWN_TYPE, InternalSpawnTypes.DROPPED_ITEM);


This adds a dropped item context to a lot of ChangeBlockEvents.
.Break (always in creative when no items drop / fire)
.Modify (tested with fire)

Faithcaio · 2017-07-23T10:52:02Z

Things to look into:

ChangeBlockEvent

Indirect ChangeBlockEvents by Gravity. (Sand falling because you broke the block below)
- Player is only the owner (probably because I placed the sand). Notifier and/or cause is missing.
Redstone activation:
- Wire is the cause? Instead of a redstone source.

Setup and Cause printout

Setup

CausePrintout

ChangeBlockEvent$Place$Impl
Tra: @-72:392 Block{minecraft:air} -> Block{minecraft:redstone_torch}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
C|1EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]


ChangeBlockEvent$Modify$Impl
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-75:392 Block{minecraft:redstone_lamp} -> Block{minecraft:lit_redstone_lamp}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
C|1SpongeLocatableBlock{blockState=minecraft:redstone_wire[east=none,north=none,power=14,south=none,west=none], position=(-74, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@75f431dd}
C|2EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]

With repeater:

ChangeBlockEvent$Place$Impl
Tra: @-70:392 Block{minecraft:air} -> Block{minecraft:redstone_torch}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]
C|1EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]


ChangeBlockEvent$Modify$Impl
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]
C|1SpongeLocatableBlock{blockState=minecraft:redstone_torch[facing=up], position=(-70, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@853c3f2}
C|2EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]


ChangeBlockEvent$Modify$Impl
Tra: @-72:392 Block{minecraft:unpowered_repeater} -> Block{minecraft:powered_repeater}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_lamp} -> Block{minecraft:lit_redstone_lamp}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-68,79, y=4,00, z=394,89]
C|1SpongeLocatableBlock{blockState=minecraft:unpowered_repeater[delay=1,facing=east,locked=false], position=(-72, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@4b1b978f}
C|2WorldServer{LevelName=world, DimensionId=0, DimensionType=minecraft:overworld}

Redstone deactivation
- Again Redstone wire is part of the cause
- Also the same block has lots of transactions in one Event

Setup and Cause printout

same setup

CausePrintout

ChangeBlockEvent$Break$Impl
Tra: @-72:392 Block{minecraft:redstone_torch} -> Block{minecraft:air}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
C|1EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]


ChangeBlockEvent$Modify$Impl
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-74:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
C|1SpongeLocatableBlock{blockState=minecraft:redstone_wire[east=none,north=none,power=0,south=none,west=none], position=(-74, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@63d24cd0}
C|2EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]


ChangeBlockEvent$Modify$Impl
Tra: @-75:392 Block{minecraft:lit_redstone_lamp} -> Block{minecraft:redstone_lamp}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,56, y=4,00, z=394,01]
C|1SpongeLocatableBlock{blockState=minecraft:lit_redstone_lamp, position=(-75, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@3b08a563}
C|2WorldServer{LevelName=world, DimensionId=0, DimensionType=minecraft:overworld}

With Repeater:

ChangeBlockEvent$Break$Impl
Tra: @-70:392 Block{minecraft:redstone_torch} -> Block{minecraft:air}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
C|1EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]


ChangeBlockEvent$Modify$Impl
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-71:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
C|1SpongeLocatableBlock{blockState=minecraft:air, position=(-70, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@132b77f6}
C|2EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]


ChangeBlockEvent$Modify$Impl
Tra: @-72:392 Block{minecraft:powered_repeater} -> Block{minecraft:unpowered_repeater}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
Tra: @-73:392 Block{minecraft:redstone_wire} -> Block{minecraft:redstone_wire}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
C|1SpongeLocatableBlock{blockState=minecraft:powered_repeater[delay=1,facing=east,locked=false], position=(-72, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@197275ae}
C|2WorldServer{LevelName=world, DimensionId=0, DimensionType=minecraft:overworld}


ChangeBlockEvent$Modify$Impl
Tra: @-74:392 Block{minecraft:lit_redstone_lamp} -> Block{minecraft:redstone_lamp}
CTX|Spawn Type: SpongeSpawnType{id=sponge:dropped_item, name=DroppedItem}
CTX|Owner: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
CTX|Notifier: EntityPlayerMP['Faithcaio'/56, l='world', x=-70,70, y=4,00, z=394,69]
C|1SpongeLocatableBlock{blockState=minecraft:lit_redstone_lamp, position=(-74, 4, 392), worldId=5cb5c3ef-3732-4ffa-afc8-2c0ac429d332, worldReference=java.lang.ref.WeakReference@22351dd5}
C|2WorldServer{LevelName=world, DimensionId=0, DimensionType=minecraft:overworld}

Linkage Error on Cause#toString when cause contains an Event. (tested with ChangeBlockEvent.Post)
Leaf Decay
- has no Owner
- SpawnType:BlockSpawning is always present.
- same LocatableBlock cause is present twice
- Leaves Decay context somehow leaks to other events. (saw it in Player-Place/Break and Sheep-Place)
Tree Grow is 2 Events Break (Sapling Block) and Place for the Rest.
- .Grow is not fired, alternative adding a grow context?

Teleport

MoveEntityEvent.Teleport
- set to Type PLUGIN on setLocation; (except when already set by plugin?)
- set to Type ENTITY_TELEPORT for Enderman
- ChorusFruit(currently only has SpongeModGame in cause (add EntityLivingBase to cause in onItemUseFinish?)
- Enderpearl (only the entity is in cause)
- set to Type COMMAND in commands
- dismountEnitiy?
- change spectator
- end portal (only back to overworld) is missing causes

Listener Code

        System.out.print(event.getClass().getSimpleName() + "\n");
        for (EventContextKey<?> key : event.getContext().keys()) {
            Object o = event.getContext().get(key).get();
            System.out.print("CTX|" + key.getName() + ": " + o + "\n");
        }

        int i = 1;
        for (Object o : event.getCause().all()) {
            if (!(o instanceof Event)) {
                System.out.print("C|" + i++ + o + "\n");
            }
        }
        System.out.print("\n\n");

Faithcaio · 2017-07-23T11:09:04Z

src/main/java/org/spongepowered/common/event/SpongeCauseStackManager.java

+                i++;
+            }
+            final PrettyPrinter printer = new PrettyPrinter(100).add("Cause Stack Frame Corruption!").centre().hr()
+                .add("Found %n frames left on the stack. Clearing them all.", offset + 1);


Found %n frames left on the stack. Clearing them all. %n is never set

Faithcaio · 2017-07-23T11:13:34Z

src/main/java/org/spongepowered/common/event/SpongeCommonEventFactory.java

-            builder.notifier(notifier);
+        try (CauseStackFrame frame = Sponge.getCauseStackManager().pushCauseFrame()) {
+            Sponge.getCauseStackManager().pushCause(source);
+            Sponge.getCauseStackManager().addContext(EventContextKeys.LIQUID_MIX, (World) worldIn);


add a LIQUID_BREAK or keep the previous LIQUID_FLOW? Nothing is mixing here

Faithcaio · 2017-07-24T19:26:12Z

src/main/java/org/spongepowered/common/event/tracking/phase/packet/PlaceBlockPacketState.java

    @Override
    public void associateBlockEventNotifier(PhaseContext context, IMixinWorldServer mixinWorldServer, BlockPos pos, IMixinBlockEventData blockEvent) {
-        final Player player = context.first(Player.class).get();
+        final Player player = Sponge.getCauseStackManager().getCurrentCause().first(Player.class).get();


Player is not present when opening inventories

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

…it is not recoverable

…iously were not being used. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

…closed. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

…cleanup. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

This was referenced Feb 15, 2017

Overhaul Cause System SpongePowered/SpongeAPI#1370

Merged

Implement overhaul of cause system SpongePowered/SpongeVanilla#299

Merged

kashike added the system: phase tracker label Feb 16, 2017

Deamon5550 force-pushed the feature/cause-and-context branch from dfb05eb to 33c7823 Compare February 26, 2017 03:52

Deamon5550 added priority: high High priority status: needs review a code review is needed labels Feb 26, 2017

kashike added the system: event label Feb 26, 2017

gabizou force-pushed the feature/cause-and-context branch from 02b7e0a to 97214d3 Compare May 15, 2017 17:46

gabizou self-requested a review May 15, 2017 17:59

gabizou force-pushed the feature/cause-and-context branch 2 times, most recently from 02b7e0a to e3342f8 Compare May 15, 2017 22:52

vectrixdevelops mentioned this pull request May 31, 2017

Teleportation vectrixdevelops/guardiansponge#18

Closed

Deamon5550 force-pushed the feature/cause-and-context branch from aa270e9 to 4ae3f0d Compare June 9, 2017 19:58

gabizou force-pushed the feature/cause-and-context branch from 4ae3f0d to 605095f Compare June 14, 2017 14:52

Deamon5550 force-pushed the feature/cause-and-context branch 2 times, most recently from d285847 to eb45cb3 Compare June 21, 2017 18:19

Deamon5550 force-pushed the feature/cause-and-context branch from eb45cb3 to 70e67bc Compare June 30, 2017 18:01

Deamon5550 requested review from Zidane and kashike as code owners July 10, 2017 03:04

gabizou force-pushed the feature/cause-and-context branch from 70e67bc to ee039b8 Compare July 10, 2017 03:04

Deamon5550 force-pushed the feature/cause-and-context branch from ee039b8 to c57abdb Compare July 14, 2017 17:53

Deamon5550 requested a review from stephan-gh as a code owner July 19, 2017 07:14

ryantheleach reviewed Jul 21, 2017

View reviewed changes

gabizou force-pushed the feature/cause-and-context branch from 9a17d01 to 1841883 Compare July 23, 2017 08:30

gabizou mentioned this pull request Jul 23, 2017

Implement Cause changes SpongePowered/SpongeForge#1670

Merged

Faithcaio reviewed Jul 23, 2017

View reviewed changes

Faithcaio reviewed Jul 24, 2017

View reviewed changes

Deamon5550 and others added 14 commits August 12, 2017 18:25

Implement cause and context refactor

b5fb6ba

Implement DamageEntityEvent changes.

42e5c8b

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Finish implementing cause refactor

0c0272a

Update for damage/health function changes

8a84b17

Fix code after rebases. Fix unit tests from unit test suite updates.

929653c

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Fix DeathPhase changes for short circuiting causing stack corruption.

f6d6ca3

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Do not reuse the id for event context keys as the name.

47683f8

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Update cause&ctx for 1.12

7303865

Fix cause stack frames

54f3213

Update some additional things, minor clean up.

d4bacfd

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Add client sidedness checks.

ac8834b

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Change popping a frame that was not in the stack back to an error as …

2bc5512

…it is not recoverable

Various small fixes. Actually use some of the context keys where prev…

3542139

…iously were not being used. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Minor fixes with rebasing updates.

62706c4

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

gabizou force-pushed the feature/cause-and-context branch from 7697ce5 to 62706c4 Compare August 13, 2017 03:27

gabizou added 3 commits August 13, 2017 00:36

Make plugin created keys automatically registered.

8029112

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Missed early stack frame popping when they are already automatically …

5be1b13

…closed. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

Various small fixes here and there with CauseStackManager usages and …

4b0801c

…cleanup. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

gabizou merged commit 4b0801c into bleeding Sep 9, 2017

gabizou added a commit that referenced this pull request Sep 9, 2017

Merge Cause and Context Implementation changes. Merges #1208.

c96a2d8

Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>

gabizou deleted the feature/cause-and-context branch September 9, 2017 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement overhaul of cause system#1208

Implement overhaul of cause system#1208
gabizou merged 17 commits intobleedingfrom
feature/cause-and-context

Deamon5550 commented Feb 15, 2017 •

edited by gabizou

Loading

Uh oh!

ryantheleach commented Jul 19, 2017

Uh oh!

Deamon5550 commented Jul 20, 2017

Uh oh!

ryantheleach Jul 21, 2017

Uh oh!

ryantheleach Jul 21, 2017 •

edited

Loading

Uh oh!

Faithcaio Jul 23, 2017 •

edited

Loading

Uh oh!

Faithcaio commented Jul 23, 2017 •

edited

Loading

Setup

CausePrintout

With repeater:

CausePrintout

With Repeater:

Listener Code

Uh oh!

Faithcaio Jul 23, 2017 •

edited

Loading

Uh oh!

Faithcaio Jul 23, 2017 •

edited

Loading

Uh oh!

Faithcaio Jul 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Deamon5550 commented Feb 15, 2017 • edited by gabizou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryantheleach commented Jul 19, 2017

Uh oh!

Deamon5550 commented Jul 20, 2017

Uh oh!

ryantheleach Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

ryantheleach Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Faithcaio Jul 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Faithcaio commented Jul 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ChangeBlockEvent

Setup

CausePrintout

With repeater:

CausePrintout

With Repeater:

Teleport

Listener Code

Uh oh!

Faithcaio Jul 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Faithcaio Jul 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Faithcaio Jul 24, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Deamon5550 commented Feb 15, 2017 •

edited by gabizou

Loading

ryantheleach Jul 21, 2017 •

edited

Loading

Faithcaio Jul 23, 2017 •

edited

Loading

Faithcaio commented Jul 23, 2017 •

edited

Loading

Faithcaio Jul 23, 2017 •

edited

Loading

Faithcaio Jul 23, 2017 •

edited

Loading