Fix a bug where a CustomInventory cannot handle inventory events#1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the old version of the implementation, the
CustomInventoryListenerchecks if the target inventory isCustomContainer. However, aCustomInventorydoes not always create aCustomContaineras its container (See CustomInventory.java), and the condition will usually return false, then the events won't be fired.There is a new way to detect if the target container does contain our custom inventory. All of the slots will be iterated, and if one of the slots belongs to our inventory, all of those related events will be fired and everything works well.
I'm the author of a chest menu plugin (ustc-zzzz/VirtualChest), and I'm trying to port my plugin to 1.12.x. It was not working until I made this commit and built a new jar for testing.