Minor code cleanup, VanillaEntityProtocol#145
Merged
Zidane merged 1 commit intospoutdev:masterfrom Apr 30, 2012
VictorD:entityProtocol
Merged
Minor code cleanup, VanillaEntityProtocol#145Zidane merged 1 commit intospoutdev:masterfrom VictorD:entityProtocol
Zidane merged 1 commit intospoutdev:masterfrom
VictorD:entityProtocol
Conversation
Signed-off-by: Victor Danell <victor.danell@gmail.com>
Zidane
pushed a commit
that referenced
this pull request
Apr 30, 2012
Minor code cleanup, VanillaEntityProtocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing big, refactored some nested if-statements into a switch and extracted the delta comparisons into a method. I feel this version is easier to follow for someone unfamiliar with the code (I might be a bit biased :P)
Signed-off-by: Victor Danell victor.danell@gmail.com